Storage limit error #846
Merged
Storage limit error #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harminius
requested changes
Dec 8, 2025
Contributor
harminius
left a comment
harminius
left a comment
There was a problem hiding this comment.
- There are commits from another PR. Best to checkout from target branch always.
- The error message construction is practically always the same. Can we create a util function to avoid code duplication?
- You could also unify the if else logic for exceptions - this could actually be a helper, e.g.
push_error_message()
…plicated error handling logic
harminius
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#843
Show a user-friendly error message when the storage limit is reached during project creation or sync instead of the raw ClientError dump.
Sync:
Creating: